[SecuritySolution][Bug] Fix to add empty values to timeline #138510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
added
Team:Threat Hunting
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
logeekal
added
release_note:skip
janmonschke
reviewed
Aug 10, 2022
x-pack/plugins/security_solution/public/common/lib/cell_actions/add_to_timeline.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
jamster10
approved these changes
Aug 10, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 10, 2022
…138510) Fixes: elastic#118846 Issue: `Add to Timeline` action was not working for empty values. https://user-images.githubusercontent.com/61860752/142180967-972a0438-154e-47c7-b058-be3abc4ac353.mp4 Solution: Empty values can be added in timeline with condition of `NOT EXISTS` and hence on `Add to Timeline` click, data provider is modified to add `NOT EXISTS` condition to the timeline. Please see demo below: https://user-images.githubusercontent.com/7485038/183914875-0b3c7e5f-7e12-40f2-a0c2-8b773434480b.mov (cherry picked from commit 07d1ec8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 10, 2022
…138510) (elastic#138556) Fixes: elastic#118846 Issue: `Add to Timeline` action was not working for empty values. https://user-images.githubusercontent.com/61860752/142180967-972a0438-154e-47c7-b058-be3abc4ac353.mp4 Solution: Empty values can be added in timeline with condition of `NOT EXISTS` and hence on `Add to Timeline` click, data provider is modified to add `NOT EXISTS` condition to the timeline. Please see demo below: https://user-images.githubusercontent.com/7485038/183914875-0b3c7e5f-7e12-40f2-a0c2-8b773434480b.mov (cherry picked from commit 07d1ec8) Co-authored-by: Jatin Kathuria <jtn.kathuria@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #118846
Issue:
Add to Timelineaction was not working for empty values.timeline_investigation.mp4
Solution:
Empty values can be added in timeline with condition of
NOT EXISTSand hence onAdd to Timelineclick, data provider is modified to addNOT EXISTScondition to the timeline. Please see demo below:Screen.Recording.2022-08-10.at.15.33.35.mov